Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions estate/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
18 changes: 18 additions & 0 deletions estate/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"name": "Estate",
"author": "sever",
"depends": [
"base",
],
"application": True,
"license": "LGPL-3",
"data": [
"views/estate_property_tag_views.xml",
"views/estate_property_type_views.xml",
"views/estate_property_offer_views.xml",
"views/estate_property_views.xml",
"views/estate_property_users_view.xml",
"views/estate_menus.xml",
"security/ir.model.access.csv",
],
}
5 changes: 5 additions & 0 deletions estate/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from . import estate_property # noqa: I001
from . import estate_property_type
from . import estate_property_tag
from . import estate_property_offer
from . import user_property
110 changes: 110 additions & 0 deletions estate/models/estate_property.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
from odoo import api, fields, models
from odoo.exceptions import UserError, ValidationError
from odoo.tools.float_utils import float_compare, float_is_zero


class EstateProperty(models.Model):
_name = "estate.property"
_description = "Estate Property Module"
_order = "id desc"

name = fields.Char(required=True)
description = fields.Text()
postcode = fields.Char()
date_availability = fields.Date(
default=fields.Date.add(fields.Date.today(), months=3),
copy=False,
)
expected_price = fields.Float(required=True)
selling_price = fields.Float(readonly=True, copy=False)
bedrooms = fields.Integer(default=2)
living_areas = fields.Integer()
facades = fields.Integer()
garage = fields.Boolean()
garden = fields.Boolean()
garden_area = fields.Integer()
garden_orientation = fields.Selection(
[("north", "North"), ("south", "South"), ("east", "East"), ("west", "West")],
)
active = fields.Boolean(default=True)
state = fields.Selection(
[
("new", "New"),
("offer_received", "Offer Received"),
("offer_accepted", "Offer Accepted"),
("sold", "Sold"),
("cancelled", "Cancelled"),
],
default="new",
required=True,
copy=False,
)
property_type_id = fields.Many2one("estate.property.type")
buyer_id = fields.Many2one("res.partner", copy=False)
seller_id = fields.Many2one("res.users", default=lambda self: self.env.user)
property_tag_ids = fields.Many2many("estate.property.tag")
offer_ids = fields.One2many("estate.property.offer", "property_id")
total_area = fields.Integer(compute="_compute_total_area")
best_price = fields.Float(compute="_compute_best_price")

_check_expected_price = models.Constraint(
"CHECK(expected_price > 0)",
"The expected price must be strictly positive.",
)
_check_selling_price = models.Constraint(
"CHECK(selling_price >= 0)",
"The selling price must be positive",
)

@api.depends("living_areas", "garden_area")
def _compute_total_area(self):
for property in self:
property.total_area = property.garden_area + property.living_areas

@api.depends("offer_ids.price")
def _compute_best_price(self):
for property in self:
property.best_price = (
max(property.offer_ids.mapped("price")) if len(property.offer_ids) > 0 else 0
)

@api.constrains("expected_price", "selling_price")
def _check_selling_price(self):
for property in self:
too_low = float_compare(property.selling_price, 0.9 * property.expected_price, 3) == -1
if not float_is_zero(property.selling_price, 3) and too_low:
msg = "The selling price cannot be lower than 90 percents of the expected price."
raise ValidationError(msg)

@api.onchange("garden")
def _onchange_garden(self):
if self.garden:
self.garden_area = 10
self.garden_orientation = "north"
else:
self.garden_area = 0
self.garden_orientation = None

@api.ondelete(at_uninstall=False)
def _unlink_if_new_or_cancelled_property(self):
for property in self:
if property.state != "new" and property.state != "cancelled":
msg = "Only new or cancelled properties can be deleted"
raise UserError(msg)
return super().unlink()
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the super().unlink() with the ondelete decorator


def action_sold_property(self):
for property in self:
if property.state == "cancelled":
msg = "Sold properties cannot be cancelled"
raise UserError(msg)
property.state = "sold"
return True

def action_cancel_property(self):
for property in self:
if property.state == "sold":
msg = "Cancelled properties cannot be sold"
raise UserError(msg)
property.state = "cancelled"
return True
79 changes: 79 additions & 0 deletions estate/models/estate_property_offer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
from odoo import api, fields, models
from odoo.exceptions import ValidationError
from odoo.tools.float_utils import float_compare


class EstatePropertyOffer(models.Model):
_name = "estate.property.offer"
_description = "Estate Property Offer"
_order = "price desc"

price = fields.Float()
status = fields.Selection(
[("accepted", "Accepted"), ("refused", "Refused")],
copy=False,
)
partner_id = fields.Many2one("res.partner", required=True)
property_id = fields.Many2one("estate.property", required=True)
validity = fields.Integer(default=7)
date_deadline = fields.Date(
compute="_compute_date_deadline",
inverse="_inverse_date_deadline",
)

_check_offer_price = models.Constraint(
"CHECK(price > 0)",
"The offer price must be strictly positive",
)

@api.depends("validity")
def _compute_date_deadline(self):
for offer in self:
if offer.create_date:
offer.date_deadline = fields.Date.add(
offer.create_date,
days=offer.validity,
)
else:
offer.date_deadline = fields.Date.add(
fields.Date.today(),
days=offer.validity,
)

def _inverse_date_deadline(self):
for offer in self:
if offer.create_date:
offer.validity = int((offer.date_deadline - offer.create_date.date()).days)
else:
offer.validity = int((offer.date_deadline - fields.Date.today()).days)

@api.model_create_multi
def create(self, vals):
for offer in vals:
linked_property = self.env["estate.property"].browse(offer["property_id"])
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid making search and browse calls on each iteration of the loop (this is quite important as it could cause performance issues). Batching the search and filtering inside the loop for the relevant results could be a better approach for that.

if float_compare(offer["price"], linked_property.best_price, 3) == -1:
msg = "Offer price cannot be lower than an existing offer"
raise ValidationError(msg)
linked_property.state = "offer_received"
return super().create(vals)

@api.constrains("status", "property_id")
def _check_south_facing_garden_accept_offer(self):
for offer in self:
price_below_expected = float_compare(offer.price, offer.property_id.expected_price, 3) == -1
if offer.status == "accepted" and offer.property_id.garden_orientation == "south" and price_below_expected:
msg = "Offers for properties with south facing garden can only be accepted if the price of the offer is above the expected price of the property"
raise ValidationError(msg)

def action_accept_offer(self):
for offer in self:
offer.status = "accepted"
offer.property_id.selling_price = offer.price
offer.property_id.buyer_id = offer.partner_id
offer.property_id.state = "offer_accepted"
return True

def action_refuse_offer(self):
for offer in self:
offer.status = "refused"
return True
15 changes: 15 additions & 0 deletions estate/models/estate_property_tag.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
from odoo import fields, models


class EstatePropertyTag(models.Model):
_name = "estate.property.tag"
_description = "Estate Property Tag"
_order = "name"

name = fields.Char(required=True)
color = fields.Integer()

_check_name_unique = models.Constraint(
"UNIQUE(name)",
"The tag name must be unique",
)
16 changes: 16 additions & 0 deletions estate/models/estate_property_type.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from odoo import fields, models


class EstatePropertyType(models.Model):
_name = "estate.property.type"
_description = "Estate Property Type"
_order = "sequence, name"

name = fields.Char(required=True)
property_ids = fields.One2many("estate.property", "property_type_id")
sequence = fields.Integer("Sequence", default=1)

_check_name_unique = models.Constraint(
"UNIQUE(name)",
"The type name must be unique",
)
9 changes: 9 additions & 0 deletions estate/models/user_property.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from odoo import fields, models


class UserProperties(models.Model):
_inherit = "res.users"

property_ids = fields.One2many(
"estate.property", "seller_id", domain=[('state', '=', 'offer_received')],
)
5 changes: 5 additions & 0 deletions estate/security/ir.model.access.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1
access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1
access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1
access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1
1 change: 1 addition & 0 deletions estate/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import test_estate_property
44 changes: 44 additions & 0 deletions estate/tests/test_estate_property.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
from odoo.exceptions import ValidationError
from odoo.tests import TransactionCase
from odoo import Command


class TestEstateProperty(TransactionCase):

@classmethod
def setUpClass(cls):
super().setUpClass()
cls.estate = cls.env['estate.property'].create({
'name': 'Super test estate',
'expected_price': 100000.0,
'state': 'new',
})
cls.test_partner = cls.env['res.partner'].create({
'name': 'Maman ours',
})

def test_estate_best_price(self):
'''
Ensure best price is correctly updated when an offer is received.
'''
self.assertEqual(self.estate.best_price, 0.0)
self.estate.offer_ids = [Command.create({
'price': 125000.0,
'partner_id': self.test_partner.id,
})]
self.assertEqual(self.estate.best_price, 125000.0)

def test_accept_offer_south_facing_garden(self):
'''
Ensure offers for estates with south-facing gardens can only be accepted if above expected
price.
'''
self.estate.expected_price = 500000
self.estate.offer_ids = [Command.create({
'price': 475000.0,
'partner_id': self.test_partner.id,
})]
self.estate.garden = True
self.estate.garden_orientation = 'south'
with self.assertRaises(ValidationError):
self.estate.offer_ids.action_accept_offer()
11 changes: 11 additions & 0 deletions estate/views/estate_menus.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<odoo>
<menuitem id="estate_menu_root" name="Real Estate">
<menuitem id="estate_advertisements_menu" name="Advertisements">
<menuitem id="estate_property_menu_action" action="estate_property_action"/>
</menuitem>
<menuitem id="estate_settings_menu" name="Settings">
<menuitem id="estate_property_type_menu_action" action="estate_property_type_action"/>
<menuitem id="estate_property_tag_menu_action" action="estate_property_tag_action"/>
</menuitem>
</menuitem>
</odoo>
35 changes: 35 additions & 0 deletions estate/views/estate_property_offer_views.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<odoo>
<record id="estate_property_offer_view_list" model="ir.ui.view">
<field name="name">estate.property.offer.list</field>
<field name="model">estate.property.offer</field>
<field name="arch" type="xml">
<list string="Offers" editable="bottom" decoration-success="status=='accepted'" decoration-danger="status=='refused'">
<field name="price"/>
<field name="partner_id" string="Partner"/>
<field name="validity" string="Validity (days)"/>
<field name="date_deadline" string="Deadline"/>
<button name="action_accept_offer" string="Accept" type="object" icon="fa-check" invisible="status == 'refused' or status == 'accepted'"/>
<button name="action_refuse_offer" string="Refuse" type="object" icon="fa-times" invisible="status == 'refused' or status == 'accepted'"/>
</list>
</field>
</record>

<record id="estate_property_offer_view_form" model="ir.ui.view">
<field name="name">estate.property.offer.form</field>
<field name="model">estate.property.offer</field>
<field name="arch" type="xml">
<form>
<sheet>
<group>
<field name="price"/>
<field name="partner_id" string="Partner"/>
<field name="validity" string="Validity (days)"/>
<field name="date_deadline" string="Deadline"/>
<field name="status"/>
</group>
</sheet>
</form>
</field>
</record>

</odoo>
8 changes: 8 additions & 0 deletions estate/views/estate_property_tag_views.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<odoo>
<record id="estate_property_tag_action" model="ir.actions.act_window">
<field name="name">Property Tags</field>
<field name="res_model">estate.property.tag</field>
<field name="view_mode">list,form</field>
</record>

</odoo>
Loading