Repository navigation
City & District: searchable, name-sorted picker sheets - #2
Merged
Merged
Conversation
Generalize the country picker sheet into a reusable PlacePickerSheet and apply it to all three levels, so City and District get the same searchable, name-sorted list (with checkmark) as Country. - Place.swift: add a NamedPlace protocol (Identifiable with String id + name) conformed by Country/City/District. - LocationPickerView: replace the City/District Pickers with tappable rows that present PlacePickerSheet; sort/filter logic now lives in the generic sheet. City selection still cascades to districts; district selection sets selectedDistrictId. - LocationPickerModel: add selectedCityName / selectedDistrictName; drop the country-specific countries(matching:) (folded into the sheet). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015bPk9UojsfzaVV4N2DWtm6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize the country picker sheet into a reusable PlacePickerSheet and apply it to all three levels, so City and District get the same searchable, name-sorted list (with checkmark) as Country.
Claude-Session: https://claude.ai/code/session_015bPk9UojsfzaVV4N2DWtm6