Use a generic icon when webapp favicon lookup fails - #11393
Open
nicknack5050 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When favicon discovery fails, installing a web app currently asks for another icon, and submitting an empty icon (or using a failing explicit icon URL) aborts installation. Use the theme's generic
web-browsericon instead so a valid app name and URL are sufficient.The interactive flow now asks only for name and URL. The CLI also accepts two arguments, while successful automatic downloads, explicit icon names/files, custom Exec commands, and MIME types retain their existing behavior.
Validation: the webapp install, escaping, and name suites pass, including new offline/failing-download cases for interactive installs, omitted icons, and explicit icon URLs. Bash syntax and
git diff --checkpass.Full
./test/all: CLI suite passed; 228 of 236 shell test files passed. Failures: bar-icon-geometry, config, launch-about, locate, runtime-smoke, snapper, unowned-system-paths, and update-lock. Bar geometry and About failures were reproduced on clean upstream 31bd80d. Several checks require a sibling omarchy-pkgs checkout absent here. The other failures are reported without attributing a cause; the two branch suites were run concurrently in a live desktop environment. None of the webapp suites failed.