Edit full legend entries and simplify figure controls - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double-clicking a legend previously exposed only the shared Low/High name and left patient/event counts outside the editor. Complete legend entries are now editable per outcome, including n/e text and rich formatting. Projects and SVG/PDF exports retain those edits; the analysis results, curves, and citation counts remain unchanged. Reset restores the automatic data label, and older shared-label projects remain compatible.
The Properties toolbar now shows compact alignment and annotation icons with hover/keyboard help. Redundant Arrange headings, alignment captions, editing hints, and repeated font descriptions were removed. The guide and screenshots explain full legend editing and the meanings of n, e, p, and q.
CPTAC currently supplies one tested outcome, so its BH-adjusted q correctly equals p. Browser and Python figures now omit the redundant q label when fewer than two outcomes have finite p-values, while JSON retains the calculation. Hiding a TCGA panel does not change the adjustment family. No statistical algorithm or data release changed.
Validation: 58 Python tests; 26 browser unit tests; 31 Playwright scenarios exercised in Chromium, Firefox, and WebKit, including full legend editing, undo, reset, reopening, older rich labels, vector export, and CPTAC/TCGA q display; 744 Python/JavaScript/R endpoint comparisons with zero failures; Ruff, build, dependency audit, and package checks. The default SRD5A1/PAAD browser figure is pixel-identical to v0.4.1 at a fixed rendering size and retains its 6.8-inch dimensions. Version 0.4.2.