Skip to content

Fix small bugs in sdflint #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akeranen wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

Fix small bugs in sdflint #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions sdflint/sdflint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,14 @@ if (require.main === module) { /* run as stand-alone? */
let schemaFile;

process.argv.slice(3).forEach((option) => {
let name = option.substring(0, option.indexOf("="));
let value = option.substring(option.indexOf("=") + 1);
let eqIndex = option.indexOf("=");
if (eqIndex === -1) {
console.error("Invalid option (missing '='): " + option);
process.exitCode = 1;
return;
}
let name = option.substring(0, eqIndex);
let value = option.substring(eqIndex + 1);
options[name] = value;
});

Expand All @@ -63,7 +69,7 @@ if (require.main === module) { /* run as stand-alone? */
sdfLint(sdfFile, schema, res, options);
console.dir(res, { depth: null });

process.exit(res.errorCount);
process.exitCode = res.errorCount;
}
else {
console.log(`
Expand All @@ -90,8 +96,7 @@ function fileNameCheck(fileName, res) {
}


function validCharsCheck(sdfFile, res) {
let sdfStr = JSON.stringify(sdfFile);
function validCharsCheck(sdfStr, res) {
if (!sdfStr) {
res.errorCount++;
res.errors.file = "Invalid SDF file";
Expand Down Expand Up @@ -140,6 +145,7 @@ function sdfLint(sdfFile, schema, res, options) {
} catch (err) {
res.errorCount++;
res.errors.parse = err.message;
return res;
}
validCharsCheck(sdfFile, res);
}
Expand Down