Fix critical bugs and stabilize automatic exploit generation module with poetry - #6
Draft
krpandrei05 wants to merge 1 commit into
Draft
Conversation
Align docker dependency with commons (==7.1.0) to resolve a Poetry version conflict, bump the base image to python:3.11 for tomllib support, follow the upstream convert.py --no-version flag rename, and strip invalid path-dependency lines from the generated requirements file before pip install. Signed-off-by: Andrei Carp <andrei.krp@gmail.com>
krpandrei05
changed the title
krpandrei05
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates dependency and container build settings for the automatic exploit generation module to reduce build/runtime conflicts and keep the pyproject.toml → requirements.txt conversion in sync with the upstream converter script.
Changes:
- Pin
dockerPython dependency to==7.1.0inpyproject.toml. - Bump Docker base image from Python 3.10 to 3.11 and update
convert.pyinvocation to use the upstream--no-versionflag. - Filter out
../...path-dependency lines from the generated module requirements prior topip install.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Pins docker dependency version for Poetry resolution. |
| docker/Dockerfile.zeratool_lib | Moves to Python 3.11, updates converter flag, and removes relative path deps from generated requirements before install. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
11
to
+13
| python = "^3.10" | ||
| pwntools = "^4.10.0" | ||
| docker = "^6.1.2" | ||
| docker = "==7.1.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align docker dependency with commons (==7.1.0) to resolve a Poetry version conflict, bump the base image to python:3.11 for tomllib support, follow the upstream convert.py --no-version flag rename, and strip invalid path-dependency lines from the generated requirements file before pip install.