Skip to content

Handle cause-less signature validation errors #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metsma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle cause-less signature validation errors #1433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions client/DigiDoc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,11 @@ QDateTime DigiDocSignature::ocspTime() const

DigiDocSignature::SignatureStatus DigiDocSignature::status(DigiDocSignature::SignatureStatus result, const digidoc::Exception &e)
{
for(const Exception &child: e.causes())
const Exception::Causes causes = e.causes();
if(causes.empty())
return std::max(result, Invalid);

for(const Exception &child: causes)
{
switch( child.code() )
{
Expand All @@ -170,7 +174,8 @@ DigiDocSignature::SignatureStatus DigiDocSignature::status(DigiDocSignature::Sig
default:
result = std::max( result, Invalid );
}
result = std::max(result, status(result, child));
if(!child.causes().empty())
result = std::max(result, status(result, child));
}
return result;
}
Expand Down