Skip to content

perf: return ImmutableContext.EMPTY from NoOpTransactionContextPropag… #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 1 commit into from
Jun 19, 2026
+7 −1
Merged

perf: return ImmutableContext.EMPTY from NoOpTransactionContextPropag… #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/dev/openfeature/sdk/NoOpTransactionContextPropagator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class NoOpTransactionContextPropagator implements TransactionContextPropa
*/
@Override
public EvaluationContext getTransactionContext() {
return new ImmutableContext();
return ImmutableContext.EMPTY;
}

/**
Expand Down
6 changes: 6 additions & 0 deletions src/test/java/dev/openfeature/sdk/NoOpTransactionContextPropagatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package dev.openfeature.sdk;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.*;

import java.util.HashMap;
Expand All @@ -16,6 +17,11 @@ public void emptyTransactionContext() {
assertTrue(result.asMap().isEmpty());
}

@Test
public void getTransactionContextReturnsEmptySingleton() {
assertThat(contextPropagator.getTransactionContext()).isSameAs(ImmutableContext.EMPTY);
}

@Test
public void setTransactionContext() {
Map<String, Value> transactionAttrs = new HashMap<>();
Expand Down
Loading