Refactor shading connections of PartialShadingDevice - #1496
Open
kldjonge wants to merge 1 commit into
Open
Conversation
Moved former shading irradiance outputs onto explicit RealExpression and pass-through blocks across the shading components. This keeps the models consistent with the shared interface but simplifies connections. This avoid illegal modelica and avoids warnings .
Member
|
@kldjonge the unit testing framework was temporarily down, but it's operational again. I have restarted the test of this PR. |
lucasverleyen
self-requested a review
July 17, 2026 15:03
Contributor
Author
|
No specific issue was made for this. But it is ready for review. But it might help for: #1328, since the original implementation didn't follow modelica-standard (which caused the warnings). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved former shading irradiance outputs onto explicit RealExpression and pass-through blocks across the shading components. This keeps the models consistent with the shared interface but simplifies connections. This avoid illegal modelica and avoids warnings.