Remove causal prefixes when using buses implemented as expandable connectors. - #1499
qlambert-pro wants to merge 1 commit into
Conversation
…nectors. `expandable connector`s have an inference mechanism to sort out the causality of signals contained in them. Adding a causal prefix makes it invalid to connect to the bus present in `IDEAS.BoundaryConditions.SimInfoManager`, for instance, as this one doesn't have such a prefix. This specific issue was originally discovered in `IDEAS.BoundaryConditions.SolarIrradiation.RadSolData` at line 176.
|
Dear @qlambert-pro I am happy to implement your suggested changes, as I could not identify any potential regressions. The conclusions of my quick impact assessment:
Based on this assessment, I am confident that the proposed changes are safe to merge. I have opened a new issue (see #1500) to implement these changes. Once the corresponding PR (#1501) has been merged, I will close this PR. |
|
Closed by #1501 |
Section 9.3 of the specs says:
expandable connectors have an inference mechanism to sort out the causality of signals contained in them. Adding a causal prefix makes it invalid to connect to the bus present inIDEAS.BoundaryConditions.SimInfoManager, for instance, as this one doesn't have such a prefix.This specific issue was originally discovered in
IDEAS.BoundaryConditions.SolarIrradiation.RadSolDataat line 176.This commit removes all prefixes use for instances of
IDEAS.Buildings.Components.Interfaces.WeaBus, an alternative to this PR would be to carefully study how the class is used and to add the appropriate causal prefixes where they are needed.I can't find a way for this commit to introduce regressions, but somehow my gut is still worried that it might, I just figured I should disclose it, as I wasn't able to fully test the outcome of the change.