-
Notifications
You must be signed in to change notification settings - Fork 99
feat: optimize disk buffering export frequency with configurable delay #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
namanONcode
wants to merge
15
commits into
open-telemetry:main
Choose a base branch
from
namanONcode:Create-configuration-parameter-for-disk-buffering-exporting-frequency-#947
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7bfcc18
feat: optimize disk buffering export frequency with configurable delay
namanONcode b853d1a
feat: add configurable export frequency for disk buffering to optimiz…
namanONcode 7b11fe0
removed ai generated documentation
namanONcode b58a737
feat: reduce default export schedule delay to 10 seconds for improved…
namanONcode 00e810b
feat: implement auto-detection for optimal export frequency based on …
namanONcode c7fa8b4
refactor: replace for loop with repeat function for improved readabil…
namanONcode ce13cf3
refactor: improve code readability by standardizing formatting in Exp…
namanONcode c32a8ca
test: enhance unit tests for ExportScheduleAutoDetector with comprehe…
namanONcode c991106
refactor: remove unused imports and improve code clarity in ExportSch…
namanONcode 693b7f0
refactor: standardize formatting in ExportScheduleAutoDetectorTest fo…
namanONcode efd0b03
refactor: rename export schedule delay constants for consistency and …
namanONcode 46499d3
refactor: remove trailing whitespace in ExportScheduleAutoDetectorTes…
namanONcode 6197112
feat: enable configuration of disk buffering export schedule delay an…
namanONcode 5a7756c
feat: Add auto-detect and delay configuration for disk buffering expo…
namanONcode cb82493
feat: externalize memory info retrieval for testability and enhance e…
namanONcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ class DefaultExportScheduleHandlerTest { | |
| periodicWork = createPeriodicWorkServiceMock() | ||
| handler = | ||
| DefaultExportScheduleHandler( | ||
| DefaultExportScheduler { periodicWork }, | ||
| DefaultExportScheduler(periodicWorkProvider = { periodicWork }), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this can be reverted |
||
| ) { periodicWork } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment is too long.