Skip to content

[rfc][confmap]: add two new approaches for merging lists across configurations#15107

Open
VihasMakwana wants to merge 3 commits intoopen-telemetry:mainfrom
VihasMakwana:configmap-rfc-update
Open

[rfc][confmap]: add two new approaches for merging lists across configurations#15107
VihasMakwana wants to merge 3 commits intoopen-telemetry:mainfrom
VihasMakwana:configmap-rfc-update

Conversation

@VihasMakwana
Copy link
Copy Markdown
Contributor

Following up on my meeting with @mx-psi, @dmitryax and @evan-bradley, I'm adding two more approaches we discussed during the meet for docs/rfcs/configuration-merging-strategy.md.

  1. Specifying the lists to merge via command line flags:
    • This approach adds separate top-level CLI flags to control the merging behaviour.
  2. Specifying the lists to merge in the configuration itself:
    • This approac uses a dedicated top-level merge: section that declares which paths in that file should be merged into the running configuration

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 13, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks
⏩ 76 skipped benchmarks1


Comparing VihasMakwana:configmap-rfc-update (d8b8738) with main (28265fc)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.27%. Comparing base (28265fc) to head (0407951).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15107   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         699      699           
  Lines       44756    44756           
=======================================
+ Hits        40850    40853    +3     
+ Misses       2766     2764    -2     
+ Partials     1140     1139    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VihasMakwana VihasMakwana changed the title [rfc][confmap]: suggest two new approaches [rfc][confmap]: suggest two new approaches for merging lists across configurations Apr 14, 2026
@VihasMakwana VihasMakwana changed the title [rfc][confmap]: suggest two new approaches for merging lists across configurations [rfc][confmap]: add two new approaches for merging lists across configurations Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant