Skip to content

Add custom attribute for payment address in checkout service #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bpschmitt wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −2
Open

Add custom attribute for payment address in checkout service #3203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ad5cdf
add custom attribute for payment address
bpschmitt Apr 2, 2026
196761c
update CHANGELOG
bpschmitt Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ the release.

## Unreleased

* [checkout] Add app.payment.service.address span attribute to chargeCard for improved payment routing observability
([#3203](https://github.com/open-telemetry/opentelemetry-demo/pull/3203))
* [product-catalog] Enrich DB spans and metrics with `server.address` and `server.port`
attributes extracted from the DSN via `otelsql.AttributesFromDSN`
([#3154](https://github.com/open-telemetry/opentelemetry-demo/pull/3154))
Expand Down
7 changes: 5 additions & 2 deletions src/checkout/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,11 +543,14 @@ func (cs *checkout) convertCurrency(ctx context.Context, from *pb.Money, toCurre

func (cs *checkout) chargeCard(ctx context.Context, amount *pb.Money, paymentInfo *pb.CreditCardInfo) (string, error) {
paymentService := cs.paymentSvcClient
paymentAddr := cs.paymentSvcAddr
if cs.isFeatureFlagEnabled(ctx, "paymentUnreachable") {
badAddress := "badAddress:50051"
c := mustCreateClient(badAddress)
paymentAddr = "badAddress:50051"
c := mustCreateClient(paymentAddr)
paymentService = pb.NewPaymentServiceClient(c)
}
span := trace.SpanFromContext(ctx)
span.SetAttributes(attribute.String("app.payment.service.address", paymentAddr))

paymentResp, err := paymentService.Charge(ctx, &pb.ChargeRequest{
Amount: amount,
Expand Down