notices: run notices-update in a container, run for amd64 and arm64#1888
notices: run notices-update in a container, run for amd64 and arm64#1888mmat11 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1888 +/- ##
==========================================
- Coverage 78.16% 78.06% -0.10%
==========================================
Files 277 277
Lines 33598 33598
==========================================
- Hits 26261 26228 -33
- Misses 6092 6121 +29
- Partials 1245 1249 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CI Supervisor
|
eb39a50 to
9d3c1a6
Compare
MrAlias
left a comment
There was a problem hiding this comment.
Thanks for updating the notice generation to keep Go notices separated per architecture. There is one release-packaging gap that still needs to be addressed.
The new layout stores notices under NOTICES/<arch>, but the release packaging step still copies the entire NOTICES/ directory into every per-architecture archive. That means an archive like obi-*-linux-amd64.tar.gz can now include arm64-only notice content as well, for example files under NOTICES/arm64/....
This is a correctness issue for released artifacts: each architecture-specific archive should only ship the notices for its own target architecture. As written, the archive contents no longer cleanly match the binary being released, and the CycloneDX SBOM generated from unpacking that archive can end up describing files that do not actually belong to that build.
Please update the release packaging flow so each per-architecture archive includes only the matching notice tree for that architecture.
Signed-off-by: Mattia Meleleo <mattia.meleleo@coralogix.com>
Signed-off-by: Mattia Meleleo <mattia.meleleo@coralogix.com>
9d3c1a6 to
4850f13
Compare
|
@MrAlias done |
Summary
Fixes #1224
This PR generates per-arch notices in NOTICES/amd64 and NOTICES/arm64. Most licenses are now duplicated, but this makes checking for diffs easier. Any custom merge approach would make the check phase more convoluted, I'm not sure it's worth it
Validation