Open
Conversation
TylerHelmuth
requested changes
Dec 22, 2025
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Run Trivy vulnerability scanner in IaC mode | ||
| uses: aquasecurity/trivy-action@0.33.1 |
Member
There was a problem hiding this comment.
What is getting scanned by trivy in the new action? We don't have any code in this repository, only references to docker images.
Author
There was a problem hiding this comment.
Trivy don't scan for code, but scan for "misconfig" in IaC files. (In this case, helm charts)
While scanning third parties charts we, we found ~18 flagged misconfigs in the otel chart. (Didn't looked if they were legit though, but all other third parties we use have none.)
Useful links:
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
ggjulio
changed the title
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Author
|
@TylerHelmuth , i'll close the pr ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivy reports +4000 issues in the security tabs. (https://github.com/ggjulio/opentelemetry-helm-charts/security/code-scanning)
But the scan can still be merged without breaking anything, later on issues can either be fixed, ignored (.trivyconfig) or closed in the security tab.