feat(collector): add resourceDetection preset for parity with the kube-stack helm chart#2157
Open
cyrille-leclerc wants to merge 8 commits intoopen-telemetry:mainfrom
Conversation
Add a resourceDetection preset to the opentelemetry-collector chart, matching the equivalent preset in the opentelemetry-kube-stack chart. Supports EKS, AKS, and GCP detectors (all disabled by default), configures the resourcedetection/env processor, and wires it into all available pipelines.
…reset Add env and k8snode as individually configurable detectors in the resourceDetection preset, matching the baseline detector set used by the opentelemetry-kube-stack chart.
Enable the env and k8snode detectors in the resourceDetection preset by default, matching the baseline behavior of the kube-stack chart which always includes these two detectors in its daemon collector config.
Add presets.resourceDetection.enabled (default: true) to allow users to fully disable the resourcedetection/env processor without having to individually disable each detector.
Set presets.resourceDetection.enabled default to false so the preset is opt-in, consistent with all other presets in the chart.
Remove env and k8snode from the example values since they are already enabled by default within the preset, and update rendered output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the PR description:
Add
resourceDetectionpreset to the opentelemetry-collector chartGoal
Implement the
presets.resourceDetectionfeature in the opentelemetry-collector chart, bringing it to parity with the equivalent preset already present in theopentelemetry-kube-stackchart (see otel-kube-stack PR here).Implementation
A new
presets.resourceDetectionblock is introduced with a top-levelenabledflag (default:falsefor backward compatibility). When set totrue, the chart injects aresourcedetection/envprocessor into all configured pipelines (logs, metrics, traces).Supported detectors
resourceDetection.enabled: true)envk8snodeeksaksgcpEach detector can be individually overridden regardless of the top-level
enabledstate.Sample configuration
Follow-up
A subsequent PR will add
presets.resourceDetectionto the opentelemetry-kube-stack chart, including theenabledflag and theenv/k8snodesub-configs. The only difference from this chart will be thatpresets.resourceDetection.enableddefaults totruethere, since the kube-stack chart already shipsresourcedetection/env(withenv+k8snode) as part of its default daemon collector configuration.