fix(opentelemetry-collector): add rbac permissions to create tokenreviews#2159
Open
ekeih wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix(opentelemetry-collector): add rbac permissions to create tokenreviews#2159ekeih wants to merge 1 commit intoopen-telemetry:mainfrom
ekeih wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
Author
|
Just noticed the CLA warning. I will not go through the CLA process for a 8 line yaml template change, but if you think my change is needed fix the underlying issue, please feel free to take the commit/change and apply in your own PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
After upgrading to
0.110.0of theopentelemetry-operatorchart theopentelemetry-operatorpods started to log an error each time their/metricsendpoint was scraped and a 500 status code is returned:Looking through the changelogs and PR history I think #2153 might have removed more than intended.
As a workaround I added the following in our setup which fixed the issue:
So as far as I understand the chart and the new authentication logic this PR should add the necessary permissions to allow scraping of the
/metricsendpoint.I see the changelog also mentions
RBAC: ClusterRole for /metrics access only created when manager.metrics.secure: true. I think this meansopentelemetry-helm-charts/charts/opentelemetry-operator/templates/clusterrole.yaml
Lines 394 to 409 in c738eda
As far as I can tell there is no
RoleBindingorClusterRoleBindingthat actually uses thisClusterRole. During debugging I was thinking that maybe this role is supposed to solve the issue I am seeing. So as an experiment I manually created aClusterRoleBindingto use this role, but it did not solve the issue.Looking at #2153 I don't understand how it could have worked withouth the
tokenreviewspermission for others. So I am wondering if maybe I am doing something wrong entirely?