Skip to content

ci: update to rust version of flint#8315

Open
zeitlinger wants to merge 3 commits intoopen-telemetry:mainfrom
zeitlinger:use-rust-flint
Open

ci: update to rust version of flint#8315
zeitlinger wants to merge 3 commits intoopen-telemetry:mainfrom
zeitlinger:use-rust-flint

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

This updates the existing link linting to the current Rust-based flint release.

What changes in this PR:

  • install flint from github:grafana/flint = "0.20.3"
  • replace the old remote lint:links shell task with flint run
  • keep the existing Lychee configuration under .github/config
  • enable check_all_local = true so local links are checked across the repo
  • preserve --full on push and scheduled runs so link checking still scans the full repo outside pull requests

Why this stays small:

  • this repo does not currently carry Markdown lint wiring to migrate here
  • the goal is only to replace the old link-check task with the released Rust flint path

Verification:

  • mise run lint
  • mise run lint --full

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger requested a review from a team as a code owner April 22, 2026 06:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (5f5b054) to head (cf1d2a4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8315   +/-   ##
=========================================
  Coverage     90.25%   90.25%           
  Complexity     7691     7691           
=========================================
  Files           850      850           
  Lines         23203    23203           
  Branches       2356     2356           
=========================================
  Hits          20943    20943           
  Misses         1532     1532           
  Partials        728      728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
GITHUB_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
PR_HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name }}
run: mise run lint:links
run: mise run lint
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you connect the dots for me here..

My read:

  • mise is ageneric task runner
  • lint is a task for mise defined in the repo to call fling run
  • Flint run is pluggable, lychee plugs in as a linter for flint - how exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants