chore: enable ruff flake8-comprehensions (C4) rules#5107
Open
yosofbadr wants to merge 2 commits intoopen-telemetry:mainfrom
Open
chore: enable ruff flake8-comprehensions (C4) rules#5107yosofbadr wants to merge 2 commits intoopen-telemetry:mainfrom
yosofbadr wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
Overall lgtm; please add a Changelog entry since this touches some code. |
Enable the C4 (flake8-comprehensions) rule set in ruff and fix all existing violations: - C401: Use set comprehension instead of set(generator) - C408: Use tuple literal () instead of tuple() - C417: Use generator expression / list comprehension instead of map(lambda) Addresses open-telemetry#4227 Assisted-by: Claude Opus 4.6
Signed-off-by: Yosof Badr <23705518+YosofBadr@users.noreply.github.com>
yosofbadr
force-pushed
the
chore/enable-ruff-rules
branch
from
39227ca to
e0add0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable the
C4(flake8-comprehensions) rule set in ruff and fix all existing violations.Fixes addressed:
set(generator)codegen/.../generator.py()instead oftuple()exporter/.../exporter.pymap(lambda)opentelemetry-sdk/.../util/__init__.pymap(lambda)shim/.../testcase.pyAddresses #4227
Type of change
How Has This Been Tested?
ruff check .with the newC4rule enabled - all checks passDoes This PR Require a Contrib Repo Change?
Checklist: