Skip to content

Apply fixes for UP ruff rule#5133

Open
emdneto wants to merge 4 commits intoopen-telemetry:mainfrom
emdneto:up-ruff-rule
Open

Apply fixes for UP ruff rule#5133
emdneto wants to merge 4 commits intoopen-telemetry:mainfrom
emdneto:up-ruff-rule

Conversation

@emdneto
Copy link
Copy Markdown
Member

@emdneto emdneto commented Apr 21, 2026

Description

  • Replaced deprecated typing.X generics (Dict, List, Set, Tuple, Type, Deque) with their built-in equivalents
  • Replaced typing.Union[X, Y] annotations with X | Y syntax (UP007)
  • Replaced typing.Optional[X] annotations with X | None syntax (UP045)

90% of the changes were made by ruff with ruff check --fix. The agent removed the unused imports and fixed minor issues.

Assisted-by: Copilot

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner April 21, 2026 22:42
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@DylanRussell
Copy link
Copy Markdown
Contributor

nice. couple failed CI checks but otherwise LGTM

@github-project-automation github-project-automation Bot moved this to Approved PRs in Python PR digest Apr 22, 2026
@emdneto emdneto moved this from Approved PRs to Ready for review in Python PR digest Apr 22, 2026
emdneto added 2 commits April 22, 2026 09:13
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Copy link
Copy Markdown
Member Author

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for manual changes i've done in 6051e44 and 874317d to make CI pass

@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants