feat: Trilogy attribute semantic convention stability#2095
feat: Trilogy attribute semantic convention stability#2095hannahramadan wants to merge 23 commits intoopen-telemetry:mainfrom
Conversation
Use double quotes in rubocop.yml
…ogy/patches/stable/client.rb Co-authored-by: Robb Kidd <robb@thekidds.org>
Include table for stable v old conventions
Co-authored-by: Robb Kidd <robb@thekidds.org>
…ogy/instrumentation.rb Co-authored-by: Robb Kidd <robb@thekidds.org>
|
|
||
| digest = Digest::MD5.new | ||
| digest.update('test') | ||
| digest.update(ENV.fetch('BUNDLE_GEMFILE', 'gemfile')) |
There was a problem hiding this comment.
This is a copy of the repo-level .simplecov, minus a guard:
digest.update(ENV.fetch('BUNDLE_GEMFILE', 'gemfile')) if ENV['APPRAISAL_INITIALIZED']
Usually appraisals are testing the same test file with different versions. They are overwriting each other's test coverage but it doesn't matter because it still looks like one file is well tested.
But now different appraisals are testing different source files and still overwriting each other's name, so it looks like code is missing tests.
The fix gives each run a unique name so all 6 results are saved and combined. When we are done with all these duplicate files, we can simply delete this file
There was a problem hiding this comment.
I'm just seeing #2272. If that is merged, i'll revert this change, merge that change in, and see if that fixes things
This PR is intended to assist in the transition from the old to new database semantic convention attribute names. Per the database semantic convention stability migration spec, users should be able to set the environment variable
OTEL_SEMCONV_STABILITY_OPT_INto:databaseto emit stable conventions onlydatabase/dupto emit both old and the stable conventionsThe agent is required to maintain this bridge for 6 months and may drop the environment variable in the next major version and emit only the stable database and networking conventions.
This approach was approved for HTTP migration in #1547
Changes (Old -> Stable):
Removed in stable:
Added in stable: