test(faraday): instrumentation test coverage#2184
Open
aabhinavvvvvvv wants to merge 6 commits intoopen-telemetry:mainfrom
Open
test(faraday): instrumentation test coverage#2184aabhinavvvvvvv wants to merge 6 commits intoopen-telemetry:mainfrom
aabhinavvvvvvv wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
aabhinavvvvvvv
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
hannahramadan,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
thompson-tomo
changed the title
|
|
||
| describe 'present' do | ||
| it 'when faraday gem is installed' do | ||
| _(instrumentation.present?).must_equal true |
Contributor
There was a problem hiding this comment.
Suggested change
| _(instrumentation.present?).must_equal true | |
| assert instrumentation.present? |
|
|
||
| it 'when Faraday is not defined' do | ||
| hide_const('Faraday') | ||
| _(instrumentation.present?).must_equal false |
Contributor
There was a problem hiding this comment.
Suggested change
| _(instrumentation.present?).must_equal false | |
| refute instrumentation.present? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves test coverage for the
faradayinstrumentation to meet the 85% SimpleCov threshold (fixes #2156).faraday_test.rbto run under thestableappraisal with tests coveringname,version,present?,compatible?, and#installon the instrumentation classenable_internal_instrumentation: truetest tostable/tracer_middleware_test.rb,old/tracer_middleware_test.rb, anddup/tracer_middleware_test.rbto cover the previously untestedelsebranch in each middleware'scallmethod