-
Notifications
You must be signed in to change notification settings - Fork 246
fix(Instrumentation-HttpClient): improve test coverage #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GRISONRF
wants to merge
9
commits into
open-telemetry:main
Choose a base branch
from
GRISONRF:fix/instrumentation-httpclient-test-coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4c7a702
test(http_client): run instrumentation tests across all appraisals
GRISONRF 44d987a
test(http_client): run instrumentation tests across all appraisals
GRISONRF 7b18742
Merge branch 'main' into fix/instrumentation-httpclient-test-coverage
thompson-tomo e05ad6d
Merge branch 'main' into fix/instrumentation-httpclient-test-coverage
thompson-tomo fb504be
Delete instrumentation/http_client/.github-ci.yml
thompson-tomo 6b3b824
Merge branch 'main' into fix/instrumentation-httpclient-test-coverage
thompson-tomo 98d12e7
Merge branch 'main' into fix/instrumentation-httpclient-test-coverage
thompson-tomo 3394684
Merge branch 'main' into fix/instrumentation-httpclient-test-coverage
thompson-tomo 29b9864
Merge branch 'main' into fix/instrumentation-httpclient-test-coverage
thompson-tomo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannahramadan Is there another way to address this? It seems to me that breaking encapsulation for the purposes of testing is probably not the best way to validate this or increase coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure test coverage is an issue any longer after merging ##2272. Here is a test run with a PR that bumps up the coverage to 85% for http_client.
@thompson-tomo as the author of this ticket, can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct, it is no longer an issue. I was letting the pr's be reviewed as any chance to improve coverage is worthwhile.
It looks like with the latest calculation it is already 100%. So happy for this PR to be closed.