fix: update simplecov to 1.0.0 - #58
Merged
Merged
Conversation
|
@xuan-cao-swi another solution is in open-telemetry/opentelemetry-ruby#2117 key thing is the finalize option. |
Contributor
Author
|
|
|
That is exactly what finalizing is for https://github.com/simplecov-ruby/simplecov#merge-finalization-ownership which even shows the forking example |
…try-ruby-instrumentation into update-simplecov
…try-ruby-instrumentation into update-simplecov
kaylareopelle
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From crmne/ruby_llm#842
Remove the check
if SimpleCov.running