Skip to content

fix: update simplecov to 1.0.0 - #58

Merged
xuan-cao-swi merged 7 commits into
open-telemetry:mainfrom
xuan-cao-swi:update-simplecov
Jul 29, 2026
Merged

fix: update simplecov to 1.0.0#58
xuan-cao-swi merged 7 commits into
open-telemetry:mainfrom
xuan-cao-swi:update-simplecov

Conversation

@xuan-cao-swi

Copy link
Copy Markdown
Contributor

From crmne/ruby_llm#842

SimpleCov.running accessor that existed in 0.22.x. It was undocumented/internal API, so its removal isn't in the breaking-changes list — but the wrapper depends on it.

Remove the check if SimpleCov.running

@xuan-cao-swi
xuan-cao-swi requested a review from a team as a code owner July 21, 2026 17:39
@thompson-tomo

Copy link
Copy Markdown

@xuan-cao-swi another solution is in open-telemetry/opentelemetry-ruby#2117 key thing is the finalize option.

@xuan-cao-swi

Copy link
Copy Markdown
Contributor Author

SimpleCov::ResultMerger.store_result is required because the tests run across multiple processes and each process generates its own isolated coverage report.

@thompson-tomo

Copy link
Copy Markdown

That is exactly what finalizing is for https://github.com/simplecov-ruby/simplecov#merge-finalization-ownership which even shows the forking example

@xuan-cao-swi
xuan-cao-swi merged commit e4688de into open-telemetry:main Jul 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants