[trace/sampling] Revises ProbabilitySampler handling when randomness is not available#5039
Open
yuanyuanzhao3 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Conversation
…ase `ot.th` key if trace ID randomness and an explicit `rv` value is not available.
yuanyuanzhao3
force-pushed
the
probabilitysampling-erase-th-no-randomness
branch
from
65a6c27 to
361d52a
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Revises
ProbabilitySamplerto avoid and/or eraseot.thkey if trace ID randomness and an explicitrvvalue is not available.Fixes #5035
For non-trivial changes, follow the change proposal process.
ot.thgeneration when randomness (trace id orrv) is absent #5035CHANGELOG.mdfile updated for non-trivial changes