chore: Clarify Exemplar applicability to async instruments#5044
Open
cijothomas wants to merge 4 commits intoopen-telemetry:mainfrom
Open
chore: Clarify Exemplar applicability to async instruments#5044cijothomas wants to merge 4 commits intoopen-telemetry:mainfrom
cijothomas wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
reyang
approved these changes
Apr 22, 2026
dashpole
approved these changes
Apr 22, 2026
Member
|
Huh.. we don't collect exemplars for asynchronous instruments, but I didn't consider the angle of capturing attributes dropped during aggregation. |
Member
Author
You mean "OTel Java" implementation don't collect exemplars right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Exemplar section's intro and bullet list currently focus heavily on trace-metric correlation, which can give the impression that Exemplars are only useful with synchronous instruments (where an active span is typically present). This PR makes two small clarifications:
Changes: