Task 1614: Fix tests that are ignored on Windows and MacOS#2724
Open
sjmsft wants to merge 8 commits intoopen-telemetry:mainfrom
Open
Task 1614: Fix tests that are ignored on Windows and MacOS#2724sjmsft wants to merge 8 commits intoopen-telemetry:mainfrom
sjmsft wants to merge 8 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2724 +/- ##
==========================================
- Coverage 87.87% 87.87% -0.01%
==========================================
Files 638 638
Lines 244608 244614 +6
==========================================
+ Hits 214942 214944 +2
- Misses 29142 29146 +4
Partials 524 524
🚀 New features to boost your workflow:
|
jmacd
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix tests that are ignored on Windows and MacOS
What issue does this PR close?
How are these changes tested?
By running the reenabled tests.
Are there any user-facing changes?
Yes, one production code change:
Windows CA certificate hot-reload fix - The get_file_identity() function now uses MetadataExt::last_write_time() (100ns-precision FILETIME) on Windows instead of the platform-fallback get_mtime() which truncated to whole seconds. Previously, if a CA certificate file was replaced within the same second (e.g., by automation or cert-manager), the file watcher could miss the change entirely, leaving stale CA certificates in memory until the next reload event. This affects any Windows deployment using mTLS with watch_client_ca: true.
All other changes are test-only (removing #[ignore] attributes and fixing test assertions for cross-platform compatibility).