-
Notifications
You must be signed in to change notification settings - Fork 348
Update exception recording guidelines to not use span events #3256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1146d0e
update exception recording guidelines to not use span events
pellared 1387714
Clarify guidance on capturing exception details in metrics and spans
pellared f9869db
Add changelog entry
pellared 095f876
Deprecate event.exception and update documentation to use logs for re…
pellared 5a37bb0
Update component designation to 'exceptions' in changelog entry
pellared 353b660
Update .chloggen/3256.yaml
pellared c16c40c
Apply suggestions from code review
pellared 370ec7c
Update docs/general/recording-errors.md
pellared a5272a5
Deprecate Semantic conventions for exceptions on spans document
pellared b340f36
Merge branch 'rem-span-events' of github.com:pellared/semantic-conven…
pellared f71de5c
revert 'event' to 'log record'
pellared e8b8f4f
update recording exceptions example
pellared ac1e486
Update recording-errors.md
pellared c9cef10
lint
pellared 97b607c
Update .github/copilot-instructions.md
pellared f3bec71
Update exceptions-spans.md to reference semantic conventions for exce…
pellared a49a364
Apply suggestion from @lmolkova
pellared ef4f629
instrumented code -> instrumented operation
pellared f0d31ea
revert deprecation of Exception event
pellared e28a464
Clarify error recording guidelines for instrumented operations and ex…
pellared 34508f8
Remove redundant instruction for recording exceptions in the document…
pellared 7519ccd
revert guidance on recording handled exceptions in documentation
pellared 4848c59
Update status link for deprecated exceptions spans documentation
pellared ec62ed5
Update deprecation note in changelog
pellared 3e0fbbd
add semicolons
pellared 668846f
Merge branch 'rem-span-events' of github.com:pellared/semantic-conven…
pellared f9e3275
format
pellared fec7b72
Clarify comments regarding error handling in createIfNotExists method
pellared 14f8c7b
Clarify comments on span status handling for ResourceAlreadyExistsExc…
pellared ee0ba3e
format
pellared File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: deprecation | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: exceptions | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Update exception recording guidelines to not use span events. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [3256] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.