Add metric requirement level#1381
Draft
joaopgrassi wants to merge 6 commits intoopen-telemetry:mainfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 119 119
Lines 9938 9947 +9
=======================================
+ Hits 8138 8142 +4
- Misses 1800 1805 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
jsuereth
reviewed
Apr 22, 2026
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Nice fixes!!!
A few thoughts --
I'm less concerned with naming for V1 - and that change is ok, we can ignore features that aren't coming to V2 syntax.
For V2 - I have a few questions:
- Should this just be
requirement_levelon themetricsection? Given there's no ambiguity in V2 now, I'd prefer to keep it simple/consistent. - If I'm refining/extending a metric, should I be able to change requirement level? My gut reaction is 'no', but wanted to check.
| pub entity_associations: Vec<String>, | ||
| /// The requirement level of the metric. Defaults to 'recommended' when omitted. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub metric_requirement_level: Option<BasicRequirementLevelSpec>, |
Contributor
There was a problem hiding this comment.
Nit: We should just call this requirement_level here - We're in a specific metrics: section, so it's mroe obvious that there should be one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406
This adds the metric requirement level to the model/schema. This will enable us to auto-generate the entire metric markdown pages, without having to enter the metric name + requirement level by hand, how it is today (which is prone to getting out-of-date as seen here)