Fix warning time comparison#665
Open
andrii-suse wants to merge 3 commits into
Open
Conversation
added 3 commits
July 13, 2026 10:35
The problem happened because of accidentally choosing a wrong line to put the format conversion
Prevent `folder_sync` and `folder_pkg_sync` tasks from scanning recursively under non-canonical symlink paths (such as `Changes -> .` loops). Previously, when scanning a non-canonical path `$path` whose `$realpath` differed from it, the tasks would register the redirect but continue recursively scanning that directory relative to `$path`. For directory loops, this resulted in an infinite loop that populated the redirect table with repeating suffixes like `/Changes/Changes/Changes`. Now, if `$realpath ne $path`, the tasks register the redirect, enqueue a new task for the canonical `$realpath` to ensure it is synchronized, schedule a mirror scan on the symlink's `Folder` record, and exit immediately. This prevents redundant scans, infinite recursive jobs, and database pollution. Also includes a new integration test (`15-local-symlink-4.sh`) verifying that directory loop symlinks do not generate nested recursive redirect records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.