Validate tool output trimmer allowlist entries#3695
Open
CodingFeng101 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trimmable_toolsiterable member is a stringWhy
ToolOutputTrimmer.trimmable_toolsaccepts a string or iterable of strings. Passing an iterable with a non-string member currently succeeds silently and stores that value in the allowlist, making configuration mistakes harder to diagnose when tool outputs are not trimmed as expected.This keeps valid string and iterable configurations unchanged, but fails fast for invalid mixed-type iterables.
Validation
python -m pytest tests/extensions/test_tool_output_trimmer.py -qpython -m ruff check src/agents/extensions/tool_output_trimmer.py tests/extensions/test_tool_output_trimmer.pypython -m ruff format --check src/agents/extensions/tool_output_trimmer.py tests/extensions/test_tool_output_trimmer.pygit diff --check