fix: infer missing streaming tool call indexes#3246
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22b6c83817
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
22b6c83 to
45f4923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index, matching Gemini OpenAI-compatible streaming responsesindexwhile continuing the sole active tool callFixes #2806.
Context
Some OpenAI-compatible streaming providers omit
delta.tool_calls[].index. The streaming chat state later indexes into accumulated tool calls with that value, which can raiseTypeError: list indices must be integers or slices, not NoneTypebefore user code sees the stream.This patch only infers an index when the stream is unambiguous: a single incoming tool call with no prior tool call becomes index
0, and a single follow-up delta reuses the sole prior tool-call index. Multi-tool or ambiguous streams remain strict.Validation
uv run --with pytest --with pytest-asyncio --with respx --with inline-snapshot --with rich pytest tests/lib/chat/test_completions_streaming.py -k 'tool_call_delta_without_index' -p no:xdist -o addopts=''-> 2 passed, 15 deselecteduv run --with pytest --with pytest-asyncio --with respx --with inline-snapshot --with rich pytest tests/lib/chat/test_completions_streaming.py -p no:xdist -o addopts=''-> 17 passeduv run --with ruff ruff check src/openai/lib/streaming/chat/_completions.py tests/lib/chat/test_completions_streaming.py-> passeduv run --with ruff ruff format src/openai/lib/streaming/chat/_completions.py tests/lib/chat/test_completions_streaming.py-> 2 files left unchangedgit diff --check-> passed