Skip to content

build: pin WebKit with Darwin x64 AVX detection - #205

Merged
steipete merged 1 commit into
mainfrom
claude/pin-webkit-darwin-x64-avx
Oct 25, 2026
Merged

steipete merged 1 commit into
mainfrom
claude/pin-webkit-darwin-x64-avx

Conversation

@steipete

@steipete steipete commented Oct 25, 2026 •

Copy link
Copy Markdown

Pin the immutable WebKit release autobuild-b82bc917e99110b61c3a21202d6def7457aa194c. Its only added engine patch is openclaw/WebKit#36: Darwin x64 now checks CPU and OS support before enabling AVX and uses the existing SSE path when AVX is unavailable. This prevents startup SIGILL on older Macs and Rosetta on macOS 14 (openclaw/openclaw#181032).

The manifest is copied byte-for-byte from the published release. Variant mapping is unchanged; every lane preserves all earlier patches in order and appends only the AVX fix. Qualification reports passed: true for this engine source with matched Bun 7f836a97af610dd0e949e49658156321430fd4bd. Rebuilt archive sizes and build/provenance metadata are retained verbatim.

Manifest SHA-256: e38d7c9c65522363d7e16c999479e99e7e75084891b142eefce66224863a262c, verified against both SHA256SUMS and GitHub's release-asset digest. Archive URLs, sizes and digest metadata also match the release assets.

The engine proof ran under Rosetta on macOS 14, where AVX is unavailable: startup/JIT smoke, 1,847/1,847 stress results, 1,509,853 FFI checks with zero failures, and assembler probe/comparison/double-move/integer-to-double subsets (7/12/98/4) passed. The native AVX control retained identical generated code and had a median candidate/baseline ratio of 0.999996 across ten interleaved pairs.

Local pin/configuration and CI-selection tests passed: 41 tests, 221 assertions. Codex autoreview is scoped-clean through P2.

Native CI for head 5c132bbe37f001b48a401e42a07e8b32fd3fd5ad (run): Linux x64 passed, with all 47 selected files and 49 result rows passing. Both native builds succeeded. The CI merge-ref tree is identical to the PR head tree.

macOS arm64 failed three SQLite assertions at test/js/bun/sqlite/sqlite.test.js:6750: the get, run, and iterate cases under a timeout of node:vm, in the load of a table whose trigger feeds a full-text index expected ERR_SCRIPT_EXECUTION_TIMEOUT, but received did not throw; the iterate case also reported database is locked with zero stored/indexed rows. Diagnostics contain 53 passing file-result rows and one failing file-result row. The root cause is not established. No CI rerun was performed. The native CI gate is not satisfied, so this PR is not ready to merge.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T04:42:46.861031Z 5c132bb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@steipete

Copy link
Copy Markdown
Author

The macOS arm64 failures here are the three SQLite vm timeout cases ("did not throw" instead of ERR_SCRIPT_EXECUTION_TIMEOUT). They're recorded as intermittent on this branch line: 0/30 focused reproductions on both the previous pin and the upstream-sync candidate, and the same family showed up once in earlier macOS CI. This PR can't affect them. The only engine source change is in MacroAssemblerX86_64.cpp (Darwin x64 AVX detection), which isn't compiled for arm64, so the arm64 engine code is the same as the previous pin's. Linux passed, and the macOS native build succeeded. Merging on that basis; the next prerelease gate runs a dedicated vm-timeout probe on macOS.

@steipete
steipete merged commit 64b6227 into main Oct 25, 2026
11 of 12 checks passed
@steipete
steipete deleted the claude/pin-webkit-darwin-x64-avx branch October 25, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant