Repository navigation
fix(process): enumerate newly assigned Windows environment variables - #81
Merged
Merged
Conversation
Adapt the native-accessor enumeration fix from oven-sh#35254 at the Windows proxy boundary, preserving its native setters and SHARE_ENV promotion. Co-authored-by: robobun <117481402+robobun@users.noreply.github.com>
steipete
force-pushed
the
w94/windows-env-enumeration
branch
from
October 3, 2026 00:13
470f001 to
fc8cc67
Compare
steipete
marked this pull request as ready for review
October 3, 2026 00:45
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning a startup-absent native environment variable such as
TZon Windows added its name to the proxy's key list but left its accessor non-enumerable. Environment copies omitted the value, and children created with those copies lost it.Make written properties enumerable while retaining their native getter/setter and SHARE_ENV promotion behavior. Adapts the enumeration fix from oven-sh#35254 (closed), credited to @robobun, at the current Windows proxy boundary.
Fork PR CI has Linux and macOS lanes and no Windows lane. Native Windows Server 2022 proof uses Node 24.21.0 as oracle:
6a5d9c721f470f0015abThe matrix preserves every previously passing assertion, every envelope exit status, and all unhandled-error counts. Both runs have 276 skips and 22 pending assertions behind the existing lazy-alias crash, addressed separately by #83. All 32 envelopes completed; 23 have exit status zero. The remaining failures are the existing W86 baseline failures. The actual Windows proxy also has two new regressions that fail before and pass after on macOS; its full file passes 12 tests with two native-Windows skips.
Unpublished build 37077657615 passed cross-build, native Windows smoke, and manifest; Publish was skipped. ZIP SHA-256:
43ea5bbe455acca40867207c9f7827fa1066741f047f691a835028422f2a7869; executable SHA-256:182bef0b54165a488b2aa5b5d97c500946b733fa3d11c437af6cd6ee40433860. Both matched locally and on Windows. The executable is unsigned and was not published.Head
fc8cc67aa75510a7e90f4297a1e140080fd47d22rebases the unchanged runtime patch onto #80. Linux and macOS CI pass on that exact head in 37081121367; the refreshed branch P2 review is scoped-clean. The final combined Windows qualification will also include #80 and the other Windows fixes. The unrelated Claude duplicate-finder action fails because its provider credentials are not configured.