feat(output): add custom headers support to kafka - #898
Open
senthilsam wants to merge 1 commit into
Open
Conversation
senthilsam
force-pushed
the
feat/add_kafka_headers
branch
from
July 25, 2026 11:25
3714d5b to
5258504
Compare
karimra
requested changes
Aug 7, 2026
karimra
left a comment
karimra
left a comment
Collaborator
There was a problem hiding this comment.
please add docs for the added config knob
Comment on lines
+715
to
+718
| headers = append(headers, sarama.RecordHeader{ | ||
| Key: []byte("sub"), | ||
| Value: []byte(m.GetMeta()["subscription-name"]), | ||
| }) |
Collaborator
There was a problem hiding this comment.
This is added unconditionally, either remove it or gate it behind a config knob.
| Topic: topic, | ||
| Value: sarama.ByteEncoder(b), | ||
| Headers: headers, | ||
| Timestamp: time.Now(), |
Collaborator
There was a problem hiding this comment.
Timestamp is not required, it is broker assigned and unrelated to the stated PR scope.
Create another PR to add it if required (behind a config knob)
Comment on lines
+708
to
+713
| for k, v := range cfg.AddHeaders { | ||
| headers = append(headers, sarama.RecordHeader{ | ||
| Key: []byte(k), | ||
| Value: []byte(v), | ||
| }) | ||
| } |
Collaborator
There was a problem hiding this comment.
Duplicated code in sync and async producers. Good to create a helper and call in both locations.
Static headers don't need to be computed for every message. Compute once, store as part of dynConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support to add custom headers to kafka message