fix: listener race condition, cleanup metrics - #901
Open
senthilsam wants to merge 1 commit into
Open
Conversation
This was referenced Jul 25, 2026
senthilsam
force-pushed
the
feat/emit-rpc-message-as-metric
branch
from
July 25, 2026 11:23
fd459fe to
cc470f9
Compare
senthilsam
force-pushed
the
feat/emit-rpc-message-as-metric
branch
from
July 31, 2026 14:39
cc470f9 to
59122b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
Target listener getting stuck during a race condition
Introduces uuid as an internal identifier for a target, so even if we remove and add quickly each time it will generate a new id, and we wil never end up gettign listener struck due to name
Clean target metrics when it's removed
Introduces gnmic_target_grpc_status_code gauge (app + collector paths) and registers it with the relevant registries.
Updates target subscription loops to set the metric to OK (0) on successful responses and to a non-OK code on subscription errors (when available).
Ensures the new per-target metric series is deleted when a target is removed.
Metric Output:
Positive case
During authentication error:
gnmic log
time=2026-07-22T09:33:39.375+05:30 level=INFO msg="subscription receive error" target=test.device.net subscription=test-sample-5m err="rpc error: code = Unauthenticated desc = Authentication has failed"Generated metric