config: apply environment overrides before unmarshal - #902
Open
dlanov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #833
GNMIC_*environment variables were merged into Viper only after theconfiguration had already been unmarshaled into
Config. As a result,nested collector configuration such as
GNMIC_CLUSTERING_LOCKER_ADDRESSwas present inFileConfigbut wasnot reflected in the configuration object stored for collector mode.
Merge environment values before unmarshaling so both global and nested
configuration fields receive environment overrides.
Add a regression test verifying that:
GNMIC_CLUSTER_NAMEpopulates the global cluster nameGNMIC_CLUSTERING_LOCKER_ADDRESSoverrides the value from the configuration fileTesting:
go test ./pkg/config -run '^TestLoadEnvironmentOverridesConfig$' -count=1 -vgo test ./... -count=1go vet ./...