collector: honor clustering TLS for cluster API clients - #903
Merged
Conversation
Collector-mode cluster dispatch used plain HTTP clients, so leader-to-member API calls ignored clustering TLS settings and could not use private CAs or present client certificates. Build the shared dispatch client from the configured clustering TLS settings after environment expansion. Preserve the existing timeout and default transport behavior when TLS is not configured. Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
karimra
approved these changes
Aug 7, 2026
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #891.
Summary
Collector-mode cluster dispatch used plain HTTP clients, so leader-to-member API calls ignored
clustering.tls. This prevented the clients from trusting private certificate authorities or presenting client certificates for mTLS.This change:
clustering.tlsafter environment expansionclustering.tlsis not configuredNewAssignerAPI unchangedTesting
go test ./pkg/collector/managers/cluster/... -count=1go test ./pkg/collector/... -count=1go build ./...go vet ./pkg/collector/...git diff --checkThe tests cover: