fix(tcp): retry messages after write failures - #905
Open
dlanov wants to merge 1 commit into
Open
Conversation
Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TCP output worker currently removes a telemetry message from its buffer before writing it to the active connection. If that write fails, the worker reconnects but does not retain the dequeued message, causing the first message at the connection failure boundary to be dropped.
This change:
Delivery across an ambiguous TCP write failure is at-least-once. A complete payload may be retried if part of it was accepted by the failed connection, but the message is no longer silently lost.
Testing
go test ./pkg/outputs/tcp_output -run 'TestTCP_(WritePayloadHandlesShortWrites|RetriesMessageAfterWriteFailure)' -count=50go test -race ./pkg/outputs/tcp_output -run 'TestTCP_(WritePayloadHandlesShortWrites|RetriesMessageAfterWriteFailure)' -count=10CGO_ENABLED=0 ./tests/run_tests.shgo vet ./...staticcheck ./pkg/outputs/tcp_outputFixes #904