Add Debug Operation - #33
Conversation
|
Hi:) currently the Execute() returns a DebugClient. |
|
For the |
|
@greg-dennis WDYT? |
greg-dennis
left a comment
There was a problem hiding this comment.
I'm not involved in the project anymore, so I don't have any kind of meaningful say over this. I made a few small comments and overall it looks alright, but you'll have to leave it to the people who are involved to say for sure.
| @@ -0,0 +1,81 @@ | |||
| // Copyright 2023 Google LLC | |||
| OTDR() otpb.OTDRClient | ||
| System() spb.SystemClient | ||
| WavelengthRouter() wrpb.WavelengthRouterClient | ||
| DEBUG() dbgpb.DebugClient |
There was a problem hiding this comment.
Should just be stylized as "Debug" not "DEBUG" because it isn't an intiailism.
| } | ||
|
|
||
| // Debug returns the client for gNOI Debug service. | ||
| func (c *Clients) DEBUG() dbgpb.DebugClient { |
|
|
||
| // Mode the commands will be executed in. | ||
| // | ||
| // enum Mode { |
There was a problem hiding this comment.
Putting the full enum in the comment creates a double-maintenance burden. I'd just let people look it up in the proto.
|
@dplore Are you the current maintainer of this project? |
|
@prinikasn may you can assist? |
gNOI Debug operation