Extend Add-path Send leaf with values ADDPATH-ECMP and ADDPATH-ALL - #1518
Extend Add-path Send leaf with values ADDPATH-ECMP and ADDPATH-ALL#1518nupkanoi wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-bgp-common.yang submodule to version 9.9.2, extending the send leaf under Add-path to support a union of boolean and explicit enumeration modes (ADDPATH_ECMP and ADDPATH_ALL). Feedback suggests keeping the parent module and other submodules in sync with this version update to avoid compilation failures, and clarifying the behavior of ADDPATH_ALL when send-max is not configured.
…rrect version and also updated ADDPATH_ALL description
|
Can we also consider adding |
|
@nupkanoi please fix the failing checks. |
This proposal extends Add-path Send leaf with values ADDPATH-ECMP and ADDPATH-ALL to add support ecmp and send all paths within add-path feature.
Platform Implementations
bgp additional-paths send ecmp (Advertises all ECMP multipaths)
bgp additional-paths send any (Advertises all paths)
bgp additional-paths send limit (Limits the best-path advertisement count)
bgp additional-paths receive
additional-paths send / additional-paths receive
additional-paths selection route-policy
RPL policy action: set path-selection multipath advertise or set path-selection all advertise.
Cisco should natively translate the enum values ADDPATH_ALL and ADDPATH_ECMP to the appropriate route-policy
Example route-policy:
Juniper (Junos)
path-count
path-selection-mode equal-cost-paths
path-selection-mode all-paths
Nokia (SR Linux)
network-instance protocols bgp afi-safi ipv4-unicast add-paths send true
send-max
Coupled with the BGP Multipath configuration (protocols bgp afi-safi ipv4-unicast multipath) to advertise ECMP ranges.
Tree View
module: openconfig-bgp-common | | | | +--rw add-paths | | | | | +--rw config | | | | | | +--rw receive? boolean - | | | | | | +--rw send? boolean + | | | | | | +--rw send? union | | | | | | +--rw send-max? uint8 | | | | | | +--rw eligible-prefix-policy? -> /oc-rpol:routing-policy/policy-definitions/policy-definition/name | | | | | +--ro state | | | | | +--ro receive? boolean - | | | | | +--ro send? boolean + | | | | | +--ro send? union | | | | | +--ro send-max? uint8 | | | | | +--ro eligible-prefix-policy? -> /oc-rpol:routing-policy/policy-definitions/policy-definition/name | | | | +--rw use-multiple-paths | | | | | +--rw config