Add fan and temperature operational leaves to platform model - #1521
Open
Verma-Anukul wants to merge 4 commits into
Open
Add fan and temperature operational leaves to platform model#1521Verma-Anukul wants to merge 4 commits into
Verma-Anukul wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-platform-ext YANG module to version 0.1.3, introducing fan speed-percentage and direction leaves, as well as critical high and low temperature threshold leaves under the component state. The review feedback suggests optimizing the speed-percentage leaf by using uint8 instead of uint32 since its range is restricted to 0..100, and enclosing the celsius unit strings in double quotes to maintain consistency with other unit definitions in the file.
Verma-Anukul
force-pushed
the
platform-extension
branch
from
July 21, 2026 10:50
158e00f to
5443956
Compare
Verma-Anukul
changed the title
Add speed-percentage (uint8, 0..100) and direction to fan-state in openconfig-platform-fan.yang (0.2.1). Add critical-high-threshold and critical-low-threshold to platform-component-temp-alarm-state in openconfig-platform.yang (0.32.1). Signed-off-by: Verma-Anukul <anukulverma2013@gmail.com>
Verma-Anukul
force-pushed
the
platform-extension
branch
from
July 21, 2026 10:50
5443956 to
8881180
Compare
Contributor
Author
|
@dplore @ElodinLaarz @navaneethyv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
speed-percentageanddirectiontofan-stateinopenconfig-platform-fan.yang(0.2.1)critical-high-thresholdandcritical-low-thresholdtoplatform-component-temp-alarm-stateinopenconfig-platform.yang(0.32.1)Motivation
These operational leaves belong in the canonical platform groupings rather than optional extension augments. Fan speed percentage, airflow direction, and temperature critical thresholds are standard platform telemetry.
References
https://www.cisco.com/c/en/us/td/docs/server_nw_virtual/2-5_release/command_reference/show.html#wp1121917
https://www.arista.com/en/um-eos/eos-environment-commands#xzx_uSqda3zF3U
https://arubanetworking.hpe.com/techdocs/AOS-CX/10.14/HTML/fundamentals_6200/Content/SysHW_cmds/sho-env-fan-10.htm
https://support.huawei.com/enterprise/en/doc/EDOC1100554480/c2f5c978/display-temperature
https://github.com/sonic-net/SONiC/blob/15e10c2a63a4b0543069bdd309721b83f23368c0/doc/pmon/pmon-chassis-design.md?plain=1#L333
Test plan