Add ingress low-TTL discard counter to interface and subinterface counters - #1527
Open
ostromart wants to merge 4 commits into
Open
Add ingress low-TTL discard counter to interface and subinterface counters#1527ostromart wants to merge 4 commits into
ostromart wants to merge 4 commits into
Conversation
This change introduces a new operational state counter in-low-ttl-discards under subinterface counters (/interfaces/interface/subinterfaces/subinterface/state/counters/in-low-ttl-discards) to track ingress packets dropped due to TTL or Hop Limit expiration. The version has been bumped to 3.9.0 in openconfig-interfaces.yang. Change-Id: I2eb15fbed7f42d17dbca3e6a789befd41993f6f9
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the openconfig-interfaces YANG module to version 3.9.0 and introduces a new in-low-ttl-discards counter to track inbound packets dropped due to expired TTL or Hop Limit. The reviewer suggested a wording improvement in the counter's description to make it more implementation-agnostic, changing 'upon routing lookup' to 'during transit forwarding'.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
|
OC operator review 28th. Looks good. Keeping in ready to discuss for further comments. |
ostromart
force-pushed
the
feature/subif-in-low-ttl-discards
branch
from
July 31, 2026 00:47
812813b to
39b09a8
Compare
This change moves in-low-ttl-discards to grouping interface-common-counters-state in openconfig-interfaces.yang so that it is visible under both /interfaces/interface/state/counters/in-low-ttl-discards and /interfaces/interface/subinterfaces/subinterface/state/counters/in-low-ttl-discards. Change-Id: I90ec73ae65c0c7f611c8f56cc230ad653ad03781
ostromart
force-pushed
the
feature/subif-in-low-ttl-discards
branch
from
July 31, 2026 00:50
39b09a8 to
0c999f7
Compare
Contributor
|
OC operator review August 4th : no comments yet, keeping it for a week before we move to the next phase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ingress low-TTL discard counter to interface and subinterface counters
This change introduces a new operational state counter
in-low-ttl-discardsunder common interface counters (/interfaces/interface/state/counters/in-low-ttl-discardsand/interfaces/interface/subinterfaces/subinterface/state/counters/in-low-ttl-discards) to track ingress packets dropped due to Time-To-Live (TTL) or Hop Limit expiration during transit forwarding.The version has been bumped to
3.9.0inopenconfig-interfaces.yang.Change-Id: I2eb15fbed7f42d17dbca3e6a789befd41993f6f9
Change Scope
in-low-ttl-discardstoopenconfig-interfaces.yang(underinterface-common-counters-state) to count ingress packets discarded on a routed interface or subinterface due to TTL or Hop Limit expiration.interface-common-counters-stategrouping.Use case
This counter is designed for production network debugging and automated failure pinpointing. Silent packet discards in routed fabrics are difficult to diagnose using generic discard counters alone. Providing an explicit counter for TTL expiration drops (
in-low-ttl-discards) allows network operators and SRE tools to quickly identify routing loops and TTL-expired discards at both interface and subinterface granularity.Platform Implementations
SAI_IN_DROP_REASON_TTL(SAI Debug Counters Proposal).show ip traffic).Router Drops -> TTL value is too small).Tree View
module: openconfig-interfaces +--rw interfaces +--rw interface* [name] ... +--ro state | +--ro counters | +--ro out-discards? oc-yang:counter64 | +--ro out-errors? oc-yang:counter64 | +--ro last-clear? oc-types:timeticks64 + | +--ro in-low-ttl-discards? oc-yang:counter64 ... +--rw subinterfaces +--rw subinterface* [index] ... +--ro state +--ro counters +--ro out-discards? oc-yang:counter64 +--ro out-errors? oc-yang:counter64 +--ro last-clear? oc-types:timeticks64 + +--ro in-low-ttl-discards? oc-yang:counter64