Repository navigation
fix(deps): distrust the compromised eMudhra CAs (0.8.1) - #43
Merged
Merged
Conversation
The private keys of eight eMudhra intermediate CAs can be recovered from their public certificates. knot's outbound TLS (OIDC, the S3 blob backend and the sqlx Postgres pool) trusted chains through them: webpki-roots 1.0.9 ships emSign ECC Root CA - G3, which cross-signs their issuer, and rustls checks neither revocation nor Certificate Transparency. - rustls-webpki 0.103.16 rejects the intermediates' keys (RUSTSEC-2026-0382). - webpki-roots 1.0.10 drops emSign ECC Root CA - G3 (RUSTSEC-2026-0381). - rustls 0.23.46 fixes RUSTSEC-2026-0346 through RUSTSEC-2026-0349. - ammonia 4.1.8 fixes RUSTSEC-2026-0373. Not reachable: the public share page uses ammonia's default builder, which strips style attributes. Kept on 4.1 rather than 4.2.4, which would pull a new html5ever stack into a patch release. - RUSTSEC-2026-0367, -0368 and -0369 (zip extract() symlink and SUID handling) are ignored in deny.toml with path, reachability and drop condition. The fix is only in zip 9, and knot never extracts: import reads the archive in memory by entry name. Adds the 0.8.1 changelog section. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
christianhuening
force-pushed
the
fix/emudhra-ca-distrust
branch
from
October 21, 2026 20:14
d881a24 to
5d72e55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security-only 0.8.1. The private keys of eight eMudhra intermediate CAs are public (incident), and knot's outbound TLS trusted chains through them: the roots are compiled into the binary, and rustls checks neither revocation nor CT, so eMudhra's revocation and the browser blocks don't reach knot. This also clears the other advisories that turned
cargo denyred onmain.The lockfile has a single
rustls-webpki, and every rustls client verifies through it:deny.tomlacknowledges RUSTSEC-2026-0367/0368/0369 (zipextract()symlink/SUID issues). The fix is only in zip 9, and knot never extracts: import reads the archive in memory by entry name.CHANGELOG.mdgets the 0.8.1 section.Evidence
main@ 9a1fedb):cargo deny check advisories→advisories FAILEDwith RUSTSEC-2026-0381, -0382, -0346, -0347, -0348, -0349, -0373, -0367, -0368, -0369After:
cargo deny check→advisories ok, bans ok, licenses ok, sources okmake lint: cleancargo nextest run --workspace --all-features: 441 passed, 2 skipped. Vitest: 405 passed.contributors_integration::revoked_editor_is_closed_with_4403_and_its_edits_are_droppedis flaky, but not because of this change: 15/30 failures onmain, 11/30 on this branch, and it already failedmainCI on 2026-10-13 (run 38418308210). If CI trips on it, re-run.Merge Danger
Door: two-way
Reverting restores the old lockfile. Publishing the v0.8.1 image afterwards is the part that can't be taken back.
Blast Radius: outbound TLS
webpki-roots1.0.10 dropsemSign ECC Root CA - G3, so a deployment whose OIDC provider, S3 endpoint or Postgres presents a chain to that root stops connecting (noted under Upgrading). No knot code changes.Follow-ups, not in this PR:
sqlxtrusting the public roots alongsidesslrootcertfor the main pool (PgBus already does it right), and the zip 9 migration.🤖 Generated with Claude Code