-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: add .gitattributes so Windows checkouts do not corrupt binary maps #4771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eastwoodgrant
wants to merge
1
commit into
openfrontio:main
Choose a base branch
from
eastwoodgrant:fix/4601-gitattributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # Prevent Git's text/EOL handling from corrupting binary assets. | ||
| # | ||
| # The repo previously had no .gitattributes, so on a default Windows clone | ||
| # (core.autocrlf=true, the Git for Windows installer default) checkout applied | ||
| # LF->CRLF conversion to binary map data: every 0x0A byte gained a 0x0D prefix, | ||
| # the file no longer matched width*height, and the game crashed on map load. | ||
| # Marking these types `binary` (a macro for `-text -diff`) makes Git check them | ||
| # out verbatim on every platform. (#4601) | ||
|
|
||
| # Map terrain data | ||
| *.bin binary | ||
|
|
||
| # Images | ||
| *.png binary | ||
| *.webp binary | ||
| *.jpg binary | ||
| *.jpeg binary | ||
| *.gif binary | ||
| *.ico binary | ||
|
|
||
| # Audio | ||
| *.mp3 binary | ||
| *.ogg binary | ||
| *.wav binary | ||
|
|
||
| # Fonts | ||
| *.woff binary | ||
| *.woff2 binary | ||
| *.ttf binary | ||
| *.otf binary | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove this comment? That history is tracked in the issue and PR, I don't think we need it as a permanent comment too