Skip to content

fix(core): guard against division by zero on 100% fallout coverage in WinCheckExecution #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berkelmali wants to merge 2 commits into
base: main
Choose a base branch
from
+42 −4
Open

fix(core): guard against division by zero on 100% fallout coverage in WinCheckExecution #4891

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ada16a
fix(core): guard against division by zero on 100% fallout coverage in…
berkelmali Aug 6, 2026
e6663c9
fix(core): guard territory win check on positive non-fallout tiles count
berkelmali Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/core/execution/WinCheckExecution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,10 @@ export class WinCheckExecution implements Execution {

const max = sorted[0];
const timeElapsed = this.mg.elapsedGameSeconds();
const numTilesWithoutFallout =
this.mg.numLandTiles() - this.mg.numTilesWithFallout();
const numTilesWithoutFallout = Math.max(
1,
this.mg.numLandTiles() - this.mg.numTilesWithFallout(),
);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
if (
(max.numTilesOwned() / numTilesWithoutFallout) * 100 >
this.mg.config().percentageTilesOwnedToWin() ||
Expand Down Expand Up @@ -162,8 +164,10 @@ export class WinCheckExecution implements Execution {
}
const max = sorted[0];
const timeElapsed = this.mg.elapsedGameSeconds();
const numTilesWithoutFallout =
this.mg.numLandTiles() - this.mg.numTilesWithFallout();
const numTilesWithoutFallout = Math.max(
1,
this.mg.numLandTiles() - this.mg.numTilesWithFallout(),
);
const percentage = (max[1] / numTilesWithoutFallout) * 100;
if (
percentage > this.mg.config().percentageTilesOwnedToWin() ||
Expand Down
Loading