Skip to content

fix(i18n): add missing multi_tab translation keys to en.json - #4923

Open
berkelmali wants to merge 1 commit into
openfrontio:mainfrom
berkelmali:fix/multi-tab-untranslated-keys
Open

fix(i18n): add missing multi_tab translation keys to en.json#4923
berkelmali wants to merge 1 commit into
openfrontio:mainfrom
berkelmali:fix/multi-tab-untranslated-keys

Conversation

@berkelmali

Copy link
Copy Markdown
Contributor

PR 4: fix(i18n): add missing multi_tab translation keys to en.json

Description:

The multi-tab warning modal (MultiTabModal.ts) renders copy using translateText() calls for the multi_tab.* namespace (multi_tab.warning, multi_tab.detected, multi_tab.please_wait, multi_tab.seconds, multi_tab.explanation).

However, the multi_tab key section was missing from resources/lang/en.json, causing the modal to render raw translation keys on-screen instead of localized text.

This PR adds the missing multi_tab translation key object to resources/lang/en.json in alphabetical order, resolving the modal's copy and satisfying EnJsonSorted.test.ts.

Please complete the following:

  • I have added screenshots for all UI updates (N/A — i18n text resolution)
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory (tests/client/MultiTabModal.test.ts)
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

barfires

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e5a939a-f892-4425-8901-fc07e84c0b51

📥 Commits

Reviewing files that changed from the base of the PR and between 508d076 and 8e5c51c.

📒 Files selected for processing (2)
  • resources/lang/en.json
  • tests/client/MultiTabModal.test.ts

Walkthrough

Added English translations for the multi-tab modal. Added a Vitest test that verifies all expected translation keys and values.

Changes

Multi-tab localization

Layer / File(s) Summary
Add and validate multi-tab translations
resources/lang/en.json, tests/client/MultiTabModal.test.ts
Added the multi_tab translation group for tab detection, the single-active-tab restriction, wait time, and warning text. Added a test for the expected keys and English values.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: Translation

Suggested reviewers: evanpelle, celant

Poem

One tab stays bright,
While others wait in quiet light.
Strings guide the way,
Tests guard each phrase today.
Vigilant mode holds tight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the missing multi_tab translation keys added to en.json, which is the main change.
Description check ✅ Passed The description explains the missing translations, the affected modal, the test coverage, and the expected fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the small-fix Small fix (≤ 50 lines) — auto-applied by PR gate label Aug 9, 2026
@ryanbarlow97

Copy link
Copy Markdown
Contributor

@berkelmali looks like prettier is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small-fix Small fix (≤ 50 lines) — auto-applied by PR gate

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants