8383868: Separate resourcehogs tests from hotspot_misc#31051
8383868: Separate resourcehogs tests from hotspot_misc#31051jsikstro wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into |
|
@jsikstro This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Hello,
While working on JDK-8383850 I looked into how resourcehog tests are being run and noticed that we run them both in the
hotspot_resourcehogsandhotspot_misctest groups.To make it more intuitive when resourcehogs are being run, I suggest we be explicit when wanting to do so, by not including them in
hotspot_miscand usinghotspot_resourcehogsdirectly instead.This might impact CI pipelines running
hotspot_miscbut nothotspot_resourcehogsin similar configurations. That will require a follow up after this if resourcehogs is still desirable to run.The folders part of the
hotspot_miscgroup are:Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31051/head:pull/31051$ git checkout pull/31051Update a local copy of the PR:
$ git checkout pull/31051$ git pull https://git.openjdk.org/jdk.git pull/31051/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31051View PR using the GUI difftool:
$ git pr show -t 31051Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31051.diff
Using Webrev
Link to Webrev Comment