Skip to content

8383868: Separate resourcehogs tests from hotspot_misc#31051

Open
jsikstro wants to merge 1 commit intoopenjdk:masterfrom
jsikstro:JDK-8383868_resourcehogs_separation_hotspot_misc
Open

8383868: Separate resourcehogs tests from hotspot_misc#31051
jsikstro wants to merge 1 commit intoopenjdk:masterfrom
jsikstro:JDK-8383868_resourcehogs_separation_hotspot_misc

Conversation

@jsikstro
Copy link
Copy Markdown
Member

@jsikstro jsikstro commented May 6, 2026

Hello,

While working on JDK-8383850 I looked into how resourcehog tests are being run and noticed that we run them both in the hotspot_resourcehogs and hotspot_misc test groups.

To make it more intuitive when resourcehogs are being run, I suggest we be explicit when wanting to do so, by not including them in hotspot_misc and using hotspot_resourcehogs directly instead.

This might impact CI pipelines running hotspot_misc but not hotspot_resourcehogs in similar configurations. That will require a follow up after this if resourcehogs is still desirable to run.

The folders part of the hotspot_misc group are:

# Before
$ jtreg -showGroups test/hotspot/jtreg/:hotspot_misc
hotspot_misc: gtest/ native_sanity/ resourcehogs/ sanity/ sources/ testlibrary/ testlibrary_tests/

# After
$ jtreg -showGroups test/hotspot/jtreg/:hotspot_misc
hotspot_misc: gtest/ native_sanity/ sanity/ sources/ testlibrary/ testlibrary_tests/


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8383868: Separate resourcehogs tests from hotspot_misc (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31051/head:pull/31051
$ git checkout pull/31051

Update a local copy of the PR:
$ git checkout pull/31051
$ git pull https://git.openjdk.org/jdk.git pull/31051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31051

View PR using the GUI difftool:
$ git pr show -t 31051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31051.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 6, 2026

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8383868: Separate resourcehogs tests from hotspot_misc

Reviewed-by: dholmes, lkorinth

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label May 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

@jsikstro The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 6, 2026

Webrevs

Copy link
Copy Markdown
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Copy Markdown
Contributor

@lkorinth lkorinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants