8383906: Target highlight in member details is too aggressive#31052
Open
hns wants to merge 2 commits intoopenjdk:masterfrom
Open
8383906: Target highlight in member details is too aggressive#31052hns wants to merge 2 commits intoopenjdk:masterfrom
hns wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review a change to improve the target highlight for javadoc member details sections.
Instead of highlighting the member header by changing its background color, we now add a subtle accent bar to the left side of the header. The bar is implemented as
box-shadow, is just outside the header element and does not cause a layout shift. It uses the theme's link color with an alpha of 70%, which seems to work well in both themes.The accent bar is wide enough to be noticeable, but nowhere near as distractive as the old highlight, and brings our documentation more in line with modern documentation/UI patterns.
I also slightly increased the
scroll-margin-topproperty of elements to position them a bit further from the navigation bar when targeted by id.Sample docs for the
java.langpackage are available here.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31052/head:pull/31052$ git checkout pull/31052Update a local copy of the PR:
$ git checkout pull/31052$ git pull https://git.openjdk.org/jdk.git pull/31052/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31052View PR using the GUI difftool:
$ git pr show -t 31052Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31052.diff
Using Webrev
Link to Webrev Comment