Skip to content

8383906: Target highlight in member details is too aggressive#31052

Open
hns wants to merge 2 commits intoopenjdk:masterfrom
hns:JDK-8383906
Open

8383906: Target highlight in member details is too aggressive#31052
hns wants to merge 2 commits intoopenjdk:masterfrom
hns:JDK-8383906

Conversation

@hns
Copy link
Copy Markdown
Member

@hns hns commented May 6, 2026

Please review a change to improve the target highlight for javadoc member details sections.

Instead of highlighting the member header by changing its background color, we now add a subtle accent bar to the left side of the header. The bar is implemented as box-shadow, is just outside the header element and does not cause a layout shift. It uses the theme's link color with an alpha of 70%, which seems to work well in both themes.

The accent bar is wide enough to be noticeable, but nowhere near as distractive as the old highlight, and brings our documentation more in line with modern documentation/UI patterns.

I also slightly increased the scroll-margin-top property of elements to position them a bit further from the navigation bar when targeted by id.

Sample docs for the java.lang package are available here.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8383906: Target highlight in member details is too aggressive (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31052/head:pull/31052
$ git checkout pull/31052

Update a local copy of the PR:
$ git checkout pull/31052
$ git pull https://git.openjdk.org/jdk.git pull/31052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31052

View PR using the GUI difftool:
$ git pr show -t 31052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31052.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 6, 2026

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the javadoc javadoc-dev@openjdk.org label May 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 6, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javadoc javadoc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant