8383856: Implementation of JEP 523: Make G1 the Default Garbage Collector in All Environments#31060
Open
tschatzl wants to merge 3 commits into
Open
8383856: Implementation of JEP 523: Make G1 the Default Garbage Collector in All Environments#31060tschatzl wants to merge 3 commits into
tschatzl wants to merge 3 commits into
Conversation
|
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Hi all, please review this change of the default collector, making G1 the only default ever selected by ergonomics. If G1 is not compiled in, the orginal logic to first try parallel and then serial has been maintained (which also necessitates keeping os::is_server_class_machine()). Testing: gha, tier1-3 Thanks, Thomas
0f6e860 to
b59610d
Compare
Webrevs
|
stefank
approved these changes
May 7, 2026
kstefanj
approved these changes
May 7, 2026
Arraying
suggested changes
May 7, 2026
stefank
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
please review this change of the default collector, making G1 the only default ever selected by ergonomics.
If G1 is not compiled in, the orginal logic to first try parallel and then serial has been maintained (which also necessitates keeping os::is_server_class_machine()).
Testing: gha, tier1-3, manually invoke the VM with various settings of maximum physical memory and available cpus (systemd-run/taskset) showing the expected behavior.
Thanks,
Thomas
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31060/head:pull/31060$ git checkout pull/31060Update a local copy of the PR:
$ git checkout pull/31060$ git pull https://git.openjdk.org/jdk.git pull/31060/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31060View PR using the GUI difftool:
$ git pr show -t 31060Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31060.diff
Using Webrev
Link to Webrev Comment