Skip to content

8383856: Implementation of JEP 523: Make G1 the Default Garbage Collector in All Environments#31060

Open
tschatzl wants to merge 3 commits into
openjdk:masterfrom
tschatzl:submit/8383856-implementation-of-jep523
Open

8383856: Implementation of JEP 523: Make G1 the Default Garbage Collector in All Environments#31060
tschatzl wants to merge 3 commits into
openjdk:masterfrom
tschatzl:submit/8383856-implementation-of-jep523

Conversation

@tschatzl
Copy link
Copy Markdown
Contributor

@tschatzl tschatzl commented May 6, 2026

Hi all,

please review this change of the default collector, making G1 the only default ever selected by ergonomics.

If G1 is not compiled in, the orginal logic to first try parallel and then serial has been maintained (which also necessitates keeping os::is_server_class_machine()).

Testing: gha, tier1-3, manually invoke the VM with various settings of maximum physical memory and available cpus (systemd-run/taskset) showing the expected behavior.

Thanks,
Thomas



Progress

  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8383863 to be approved
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8383856: Implementation of JEP 523: Make G1 the Default Garbage Collector in All Environments (Enhancement - P4)
  • JDK-8383863: JEP 523: Make G1 the Default Garbage Collector in All Environments (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31060/head:pull/31060
$ git checkout pull/31060

Update a local copy of the PR:
$ git checkout pull/31060
$ git pull https://git.openjdk.org/jdk.git pull/31060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31060

View PR using the GUI difftool:
$ git pr show -t 31060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31060.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 6, 2026

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title 8383856 8383856: Implementation of JEP 523: Make G1 the Default Garbage Collector in All Environments May 6, 2026
@openjdk openjdk Bot added csr Pull request needs approved CSR before integration hotspot-gc hotspot-gc-dev@openjdk.org labels May 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 6, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

Hi all,

  please review this change of the default collector, making G1 the only default ever selected by ergonomics.

If G1 is not compiled in, the orginal logic to first try parallel and then serial has been maintained (which also necessitates keeping os::is_server_class_machine()).

Testing: gha, tier1-3

Thanks,
  Thomas
@tschatzl tschatzl force-pushed the submit/8383856-implementation-of-jep523 branch from 0f6e860 to b59610d Compare May 6, 2026 15:02
@tschatzl tschatzl marked this pull request as ready for review May 7, 2026 07:52
@openjdk openjdk Bot added the rfr Pull request is ready for review label May 7, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 7, 2026

Webrevs

Comment thread src/hotspot/share/gc/shared/gcConfig.cpp Outdated
Copy link
Copy Markdown
Member

@Arraying Arraying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

csr Pull request needs approved CSR before integration hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants